RFR: 8308762: Metaspace leak with Instrumentation.retransform [v3]

Jean-Philippe Bempel jpbempel at openjdk.org
Tue Jul 18 16:43:37 UTC 2023


> Fix a small leak in constant pool merging during retransformation of a class. If this class has a catch block with `Throwable`, the class `Throwable` is pre-resolved in the constant pool, while all the other classes are in a unresolved state. So the constant pool merging process was considering the entry with pre-resolved class as different compared to the destination and create a new entry. We now try to consider it as equal specially for Methodref/Fieldref.

Jean-Philippe Bempel has updated the pull request incrementally with one additional commit since the last revision:

  Revert resolved class to unresolved for comparison
  
  remove is_unresolved_class_mismatch

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14780/files
  - new: https://git.openjdk.org/jdk/pull/14780/files/2ff1721b..05071a56

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14780&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14780&range=01-02

  Stats: 45 lines in 3 files changed: 7 ins; 38 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/14780.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14780/head:pull/14780

PR: https://git.openjdk.org/jdk/pull/14780


More information about the serviceability-dev mailing list