RFR: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
David Holmes
dholmes at openjdk.org
Wed Jul 26 05:33:52 UTC 2023
On Tue, 25 Jul 2023 21:48:24 GMT, Paul Hohensee <phh at openjdk.org> wrote:
> MonitoringSupport_lock is initialized only when UseG1GC is true, but [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) uses it to implement getTotalThreadAllocatedBytes, which is available for all garbage collectors. While the current code sets UseG1GC regardless of which collector is specified, see FLAG_SET_ERGO_IF_DEFAULT(UseG1GC, true) in gcConfig.cpp, if G1 isn't included in the Hotspot build or Hotspot is not running on a server class machine (unlikely these days), the lock will not be initialized. The lock's initialization should be unconditional.
>
> I updated ThreadAllocatedMemory.java to run the test using both G1 and Serial collectors.
Looks good.
Thanks.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15028#pullrequestreview-1546852702
More information about the serviceability-dev
mailing list