RFR: 8304438: jcmd JVMTI.agent_load should obey EnableDynamicAgentLoading [v3]

[David Holmes]

On Wed, 31 May 2023 23:39:19 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The VM option EnableDynamicAgentLoading was added in JDK 9, default true, to allow deployment to choose whether to allow agents to be loaded/started in the VM. The VM option does the right thing for tools using the Attach API but jcmd JVMTI.agent_load was missed. This should be fixed to disallow loading JVMTI agents when the EnableDynamicAgentLoading is false.
>> 
>> Testing:
>>  - run new test `test/jdk/sun/tools/jcmd/TestJcmdNoAgentLoad.java`
>>  - TBD: submit mach5 tiers 1-5 to make sure no new regressions are introduced
>
> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move check for EnableDynamicAgentLoading to invoke_Agent_OnAttach

A change in behaviour like this requires a CSR request - the code has been doing the wrong thing for a long time now!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14244#issuecomment-1571218267