RFR: JDK-8306441: Enhance parallel heap dump [v6]
Yi Yang
yyang at openjdk.org
Tue Jun 6 01:49:54 UTC 2023
On Mon, 5 Jun 2023 23:44:04 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
> A lot of code movement is caused by moving AbstractDumpWriter class from heapDumper.cpp to heapDumpCompression.hpp/cpp
> I'm not happy with huge heapDumper.cpp file, but this refactoring does not look good to me.
> Currently all logic about hprof file structure is in heapDumper.cpp, it's not visible outside.
> With your fix the logic is spread in heapDumper.hpp/.cpp and heapDumpCompression.hpp/cpp
I will undo all refactor code. Let us firstly focuse on proposal itself. The refactor can be discussed later.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13667#issuecomment-1577770928
More information about the serviceability-dev
mailing list