RFR: 8309510: com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java no longer needs to override startUp() method

Chris Plummer cjplummer at openjdk.org
Wed Jun 7 18:00:32 UTC 2023


On Tue, 6 Jun 2023 00:36:12 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java currently overrides the TestScaffold.startup() method:
> 
>     // override this to correct a bug so arguments can be passed to
>     // the Target class
>     protected void startUp(String targetName) {
>         List<String> argList = new ArrayList<>(Arrays.asList(args));
>         argList.add(0, targetName); // pre-pend so it becomes the first "app" arg
>         println("run args: " + argList);
>         connect((String[]) argList.toArray(args));
>         waitForVMStart();
>     }
> 
> This issue of passing app args was fixed recently by [JDK-8308481](https://bugs.openjdk.org/browse/JDK-8308481), so the override is no longer needed.

Thanks for the reviews Alex and Serguei!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14325#issuecomment-1581267545


More information about the serviceability-dev mailing list