RFR: 8309673: Refactor ref_at methods in Serviceability ConstantPool

[Coleen Phillimore]

On Thu, 8 Jun 2023 21:42:24 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

> The accessor methods in constantpool.cpp were previously cleaned up to allow for different types of indices to be used, distinguishing them by the bytecode. This patch adds the same changes to the hotspot serviceability code. Verified with tier 1-5 tests.

Looks good.

src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java line 262:

> 260:       case Bytecodes._invokedynamic:
> 261:         int poolIndex = getCache().getIndyEntryAt(index).getConstantPoolIndex();
> 262:         return poolIndex = invokeDynamicNameAndTypeRefIndexAt(poolIndex);

probably don't need another assignment to poolIndex in the return statement.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14385#pullrequestreview-1472334909
PR Review Comment: https://git.openjdk.org/jdk/pull/14385#discussion_r1224416163