RFR: 8309673: Refactor ref_at methods in SA ConstantPool [v2]

[Ioi Lam]

On Fri, 9 Jun 2023 18:14:18 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The accessor methods in constantpool.cpp were previously cleaned up to allow for different types of indices to be used, distinguishing them by the bytecode. This patch adds the same changes to the hotspot serviceability agent code. Verified with tier 1-5 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Removed unnecessary assignment

LGTM. I would suggest changing "Serviceability" in the title to "SA"

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14385#pullrequestreview-1472921430