RFR: 8309752: com/sun/jdi/SetLocalWhileThreadInNative.java fails with virtual test thread factory due to OpaqueFrameException [v2]

Chris Plummer cjplummer at openjdk.org
Sat Jun 10 02:56:47 UTC 2023


> com/sun/jdi/SetLocalWhileThreadInNative.java is failing with OpaqueFrameException when using the virtual test thread factory. The reason is because JDI only supports calling StackFrame.setValue() on the topmost frame of a virtual thread. The test is calling it on the ThreadReference.frames(2), so the OpaqueFrameException is correct behavior and the test needs to adapt.
> 
> I could have chosen to just not have this test support running on a virtual thread, but it appears to be the only test we have that attempts StackFrame.setValue() on something other than the topmost frame, so it's good to have it expect the OpaqueFrameException.
> 
> Tested locally with and without the virtual thread wrapper. tier1 and tier5 svc testing tbd.

Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:

  caughtOPE -> caughtOFE

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14402/files
  - new: https://git.openjdk.org/jdk/pull/14402/files/ee21d434..2799ebe6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14402&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14402&range=00-01

  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/14402.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14402/head:pull/14402

PR: https://git.openjdk.org/jdk/pull/14402


More information about the serviceability-dev mailing list