RFR: 8308499: Test vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001/TestDescription.java failed: VMDisconnectedException

[Leonid Mesnik]

On Wed, 14 Jun 2023 23:13:59 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/jdi/MethodExitRequest/addClassExclusionFilter/filter001.java line 77:
>> 
>>> 75:     private String classExclName1 = "java";
>>> 76:     private String classExclName2 = "sun";
>>> 77:     private String classExclName3 = "jdk";
>> 
>> The fix is reasonable. However,
>> I think it would be better to use List<String> with List.of(...) and list.contains() to filter exclusions.
>
> With 3 items it's borderline which approach to do. I find it easier to read the way it is now, especially checking the event classname, since it would require a loop that sets a flag that then has to be checked outside of the loop.

If you think it is easier, then fine.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14480#discussion_r1230374885