RFR: 8309979: BootstrapMethods attribute is missing in class files recreated by SA [v2]

[Ashutosh Mehra]

On Thu, 15 Jun 2023 18:15:41 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address review comments by plummercj
>>   
>>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java line 498:
> 
>> 496:     U2Array operands = getOperands();
>> 497:     if (operands == null)  return null;  // safety first
>> 498:     int basePos = getOperandOffsetAt(bsmIndex);
> 
> Maybe you should pass `operands` into `getOperandOffsetAt()` so it does not need to be fetched again.

Done.

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java line 694:
> 
>> 692:         if (bsmCount != 0)
>> 693:             classAttributeCount++;
>> 694: 
> 
> Please use curly braces here.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14495#discussion_r1231495232
PR Review Comment: https://git.openjdk.org/jdk/pull/14495#discussion_r1231495480