RFR: JDK-8306441: Two-stage Segmented Heap Dump [v10]
Alex Menkov
amenkov at openjdk.org
Sat Jun 17 01:26:29 UTC 2023
On Sat, 17 Jun 2023 00:22:09 GMT, Alex Menkov <amenkov at openjdk.org> wrote:
>> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> whitespace
>
> src/hotspot/share/services/diagnosticCommand.cpp line 474:
>
>> 472: _overwrite("-overwrite", "If specified, the dump file will be overwritten if it exists",
>> 473: "BOOLEAN", false, "false"),
>> 474: _parallel("-parallel", "Number of parallel dump thread, it should be less than ParallelGCThread",
>
> dump threadS.
> Not sure it makes sense to mention ParallelGCThread (according to how the option is handled).
> Maybe something like
> "Number of parallel threads to use for heap dump. The VM will try to use the specified number of threads, but might use fewer."
This change adds new option. most likely this requires CSR
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13667#discussion_r1232922184
More information about the serviceability-dev
mailing list