RFR: 8242152: SA does not include StackMapTables when dumping .class files [v2]

[Daohan Qu]

On Wed, 21 Jun 2023 20:19:59 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Daohan Qu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix some code format issues
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstMethod.java line 113:
> 
>> 111:   private static MetadataField constants;
>> 112:   // Raw stackmap data for the method (#entries + entries)
>> 113:   private static AddressField stackMapData;
> 
> I think putting the comment on the same line as the declaration would be better

Ok

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java line 173:
> 
>> 171:         // Code attributes
>> 172:         Short stackMapTableIndex = utf8ToIndex.get("StackMapTable");
>> 173:         _stackMapTableIndex = (stackMapTableIndex != null)?
> 
> Add a space before the `?`

Ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14556#discussion_r1237920892
PR Review Comment: https://git.openjdk.org/jdk/pull/14556#discussion_r1237921127