RFR: 8242152: SA does not include StackMapTables when dumping .class files [v2]

Thu Jun 22 04:00:16 UTC 2023

On Thu, 22 Jun 2023 02:37:08 GMT, Daohan Qu <dqu at openjdk.org> wrote:

>> This patch adds `StackMapTable` for the class files generated by `clhsdb`'s `buildreplayjars` command. This bug manifests itself during my diagnosing [JDK-8309751](https://bugs.openjdk.org/browse/JDK-8309751) and needs to be fixed first.
>> 
>> I have run jtreg test `tier1-3` of release build on x86 linux finding only one failure in `tier2` caused by [JDK-8309214](https://bugs.openjdk.org/browse/JDK-8309214). `jtreg:test/hotspot/jtreg/serviceability` and `jtreg:test/jdk/sun/tools/` also passed.
>
> Daohan Qu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix some code format issues

A simple check has been added. For optional attributes like `StackMapTable`, a comprehensive check would involve comparing the original class file with the generated one. However, I believe that this deserves another PR.

FYI, `jtreg:test/hotspot/jtreg/serviceability` still passes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14556#issuecomment-1601974520