RFR: 8294316: SA core file support is broken on macosx-x64 starting with macOS 12.x

[Chris Plummer]

On Tue, 20 Jun 2023 18:05:09 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> This is a minor fix to core file reading on macos x.  I can confirm that after this fix I can run the problem listed SA core file tests on Ventura.

Marked as reviewed by cjplummer (Reviewer).

src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c line 309:

> 307:         print_debug("LC_SEGMENT_64 added: nsects=%d fileoff=0x%llx vmaddr=0x%llx vmsize=0x%llx filesize=0x%llx %s\n",
> 308:                     segcmd.nsects, segcmd.fileoff, segcmd.vmaddr, segcmd.vmsize,
> 309:                     segcmd.filesize, &segcmd.segname[0]);

It would be nice to include this print_debug for the `filesize == 0` case. Maybe you can move it outside of the `if` and print `added` or `skipped` conditional on `filesize`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/14569#pullrequestreview-1491727136
PR Review Comment: https://git.openjdk.org/jdk/pull/14569#discussion_r1237613357