RFR: 8305341: Alignment should be enforced by alignas instead of compiler specific attributes [v5]

Fri Jun 23 05:58:15 UTC 2023

On Fri, 23 Jun 2023 02:25:47 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Whitespace
>>  - Revert
>>  - _MSC_VER
>
> @djelinski Sorry for the tag, it's just that this PR has been collecting dust for months now

Hi @TheShermanTanker these alignment instructions were introduced in JDK-8220348 and JDK-8239856 to deal with Windows 32 failures. Windows 32 build is going away soon. As far as I could tell, the declspec was only introduced to deal with an overzealous assert.

@TheRealMDoerr @RealCLanger @tstuefe @sspitsyn since you were responsible for the introduction of the alignment specifiers, could you help with reviewing this?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13258#issuecomment-1603717283