RFR: 8310906: Fix -Wconversion warnings in runtime, oops and some code header files. [v4]
Frederic Parain
fparain at openjdk.org
Wed Jun 28 17:30:54 UTC 2023
On Wed, 28 Jun 2023 13:17:21 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> This is another version of PR https://github.com/openjdk/jdk/pull/14659 but I've added a pointer delta function in globalDefinitions.hpp to use for these pointer diff calculations that return int everywhere. If the name is agreeable, I'll fix the other cases of this like this. It's better than raw casts.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Use pointer_delta_as_int for the name that uses pointer_delta, fix negative case to just do checked_cast.
Looks good to me.
-------------
Marked as reviewed by fparain (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14675#pullrequestreview-1503631614
More information about the serviceability-dev
mailing list