RFR: 8303489: Add a test to verify classes in vmStruct have unuque vtables [v2]

[Alex Menkov]

On Thu, 2 Mar 2023 16:09:51 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressed feedback
>
> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 96:
> 
>> 94:         Map<Address, List<Type>> types = new HashMap<>();
>> 95:         Iterator<Type> it = agent.getTypeDataBase().getTypes();
>> 96:         int dupFound = 0;
> 
> Should be "dupsFound"

Fixed.

> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 118:
> 
>> 116:                   + ", JPrimitive: " + t.isJavaPrimitiveType()
>> 117:                   + ", Oop: " + t.isOopType()
>> 118:                   + ", Ptr: " + t.isPointerType());
> 
> It appears that these always print "false". Are they worth having?

It reports all available info about the Type. As these are "suspicious" types I think it make sense to provide more info

-------------

PR: https://git.openjdk.org/jdk/pull/12820