RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v7]

David Holmes dholmes at openjdk.org
Fri Mar 3 05:30:14 UTC 2023


On Tue, 28 Feb 2023 06:17:29 GMT, Yi Yang <yyang at openjdk.org> wrote:

>> harmless refactor to share code across different platforms of VirtualMachineImpl:
>> 1. Shared code to process command response after requesting a command execution
>> 2. Read functionality in SocketInputStream can be reused
>
> Yi Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fd set -1

Nothing further from me.

Thanks.

src/jdk.attach/share/classes/sun/tools/attach/HotSpotVirtualMachine.java line 375:

> 373:      * Utility method to process the completion status after command execution.
> 374:      * If we get IOE during previous command execution, delay throwing it until
> 375:      * completion status have been read.

Nit: s/have/has/

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11823


More information about the serviceability-dev mailing list