RFR: 8303151: DCmd framework cleanups [v2]

Thomas Stuefe stuefe at openjdk.org
Sat Mar 4 09:16:11 UTC 2023


On Sat, 4 Mar 2023 08:50:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Whilst working on the DCmd code I noticed two items that could be cleaned up:
>> 
>> 1. The `NMTDCmd` is registered after the call to `register_dcmds()` instead of inside it.
>> 
>> 2. The "extension" mechanism to define external DCmds (as added by [JDK-7132515](https://bugs.openjdk.org/browse/JDK-7132515) for `UnlockCommercialFeatures`) is no longer needed.
>> 
>> Testing: tiers 1-3
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix comment

+1

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/12847


More information about the serviceability-dev mailing list