RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry

[Matias Saavedra Silva]

On Tue, 7 Mar 2023 13:39:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The current structure used to store the resolution information for invokedynamic, ConstantPoolCacheEntry, is difficult to interpret due to its ambigious fields f1 and f2. This structure can hold information for fields, methods, and invokedynamics and each of its fields can hold different types of values depending on the entry. 
>> 
>> This enhancement proposes a new structure to exclusively contain invokedynamic information in a manner that is easy to interpret and easy to extend.  Resolved invokedynamic entries will be stored in an array in the constant pool cache and the operand of the invokedynamic bytecode will be rewritten to be the index into this array.
>> 
>> Any areas that previously accessed invokedynamic data from ConstantPoolCacheEntry will be replaced with accesses to this new array and structure. Verified with tier1-9 tests.
>> 
>> The PPC was provided by @reinrich and the RISCV port was provided by @DingliZhang and @zifeihan.
>> 
>> This change supports the following platforms: x86, aarch64, PPC, and RISCV
>
> src/hotspot/share/ci/ciReplay.cpp line 419:
> 
>> 417:       be used to avoid multiple blocks of similar code. When CPCE is obsoleted
>> 418:       these can be removed
>> 419:       */
> 
> I don't know if you really need this comment.  If so, use // style instead.

I think it's worth keeping around as a reminder for cleanup down the line since it's easy to overlook. I will change it to // style.

-------------

PR: https://git.openjdk.org/jdk/pull/12778