RFR: 8257967: JFR: Events for loaded agents [v4]

Markus Grönlund mgronlun at openjdk.org
Thu Mar 9 09:32:19 UTC 2023


The message from this sender included one or more files
which could not be scanned for virus detection; do not
open these files unless you are certain of the sender's intent.

----------------------------------------------------------------------
On Wed, 8 Mar 2023 22:56:31 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - remove JVMPI
>>  - cleanup
>
> src/hotspot/share/runtime/threads.cpp line 338:
> 
>> 336:   if (EagerXrunInit && Arguments::init_libraries_at_startup()) {
>> 337:     create_vm_init_libraries();
>> 338:   }
> 
> Not obvious where this went. Changes to the initialization order can be very problematic.

Thanks, David. Two calls to launch XRun agents are invoked during startup, and they depend on the EagerXrunInit option. The !EagerXrunInit case is already located in create_vm(), but the EagerXrunInit was located as the first entry in initialize_java_lang_classes(), which I thought was tucked away a bit unnecessarily.

I hoisted the EagerXrunInit from initialize_java_lang_classes() into to create_vm(). It's now the call just before initialize_java_lang_classes().

This made it clearer, i.e. to have both calls located directly in create_vm().

-------------

PR: https://git.openjdk.org/jdk/pull/12923


More information about the serviceability-dev mailing list