RFR: 8303814: getLastErrorString should avoid charset conversions [v2]

Daniel Jeliński djelinski at openjdk.org
Mon Mar 13 09:48:22 UTC 2023


On Fri, 10 Mar 2023 21:47:45 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Daniel Jeliński has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Address review comments
>>  - Mention that the returned text is static and thread safe
>>  - Define buffer size
>
> src/java.base/share/native/libjava/jni_util.c line 133:
> 
>> 131:     if (s != NULL) {
>> 132:         jobject x = NULL;
>> 133:         if (messagelen) {
> 
> Avoid implicit compare with 0; use `messagelen > 0` or similar.

preexisting, but fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/12922


More information about the serviceability-dev mailing list