RFR: 8257967: JFR: Events for loaded agents [v10]

Andrew Dinn adinn at openjdk.org
Mon Mar 13 09:52:38 UTC 2023


On Mon, 13 Mar 2023 06:29:11 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more cleanup
>
> src/hotspot/share/prims/agentList.cpp line 64:
> 
>> 62: void AgentList::add_xrun(const char* name, char* options, bool absolute_path) {
>> 63:   Agent* agent = new Agent(name, options, absolute_path);
>> 64:   agent->_is_xrun = true;
> 
> Why direct access of private field instead of having a setter like other parts of the Agent API?

n.b. that also applies for accesses/updates to field _next.

-------------

PR: https://git.openjdk.org/jdk/pull/12923


More information about the serviceability-dev mailing list