RFR: 8303921: serviceability/sa/UniqueVtableTest.java timed out [v2]

Alex Menkov amenkov at openjdk.org
Wed Mar 15 00:37:18 UTC 2023


On Tue, 14 Mar 2023 23:41:47 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/sa/UniqueVtableTest.java line 195:
>> 
>>> 193:         } else {
>>> 194:             runTest(Long.parseLong(args[0]));
>>> 195:         }
>> 
>> Could use some comments here. Also, I think `SATestUtils.skipIfCannotAttach` is only needed for the `else` part.
>
> "else" part is a sub-process.
> As far as I understand it SATestUtils.skipIfCannotAttach can be skipped for "else", but it's needed for main process.

Added comment.
Left SATestUtils.skipIfCannotAttach as is (this is consistent with other SA tests)

-------------

PR: https://git.openjdk.org/jdk/pull/13030


More information about the serviceability-dev mailing list