RFR: 8294977: Convert test/jdk/java tests from ASM library to Classfile API [v3]
Chen Liang
liach at openjdk.org
Thu Mar 16 15:03:58 UTC 2023
> Summaries:
> 1. A few recommendations about updating the constant API is made at https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html and I may update this patch shall the API changes be integrated before
> 2. One ASM library-specific test, `LambdaAsm` is removed. Others have their code generation infrastructure upgraded from ASM to Classfile API.
> 3. Most tests are included in tier1, but some are not:
> In `:jdk_io`: (tier2, part 2)
>
> test/jdk/java/io/Serializable/records/SerialPersistentFieldsTest.java
> test/jdk/java/io/Serializable/records/ProhibitedMethods.java
> test/jdk/java/io/Serializable/records/BadCanonicalCtrTest.java
>
> In `:jdk_instrument`: (tier 3)
>
> test/jdk/java/lang/instrument/RetransformAgent.java
> test/jdk/java/lang/instrument/NativeMethodPrefixAgent.java
> test/jdk/java/lang/instrument/asmlib/Instrumentor.java
>
>
> @asotona Would you mind reviewing?
Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- Fix failed LambdaStackTrace test, use more convenient APIs
- Merge branch 'master' of https://git.openjdk.java.net/jdk into invoke-test-classfile
- Shorten lines, move from mask() to ACC_ constants, other misc improvements
- Convert test/jdk/java ASM tests to classfile api
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/13009/files
- new: https://git.openjdk.org/jdk/pull/13009/files/c6536bf9..a50b94f9
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=13009&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=13009&range=01-02
Stats: 68505 lines in 534 files changed: 42498 ins; 18129 del; 7878 mod
Patch: https://git.openjdk.org/jdk/pull/13009.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/13009/head:pull/13009
PR: https://git.openjdk.org/jdk/pull/13009
More information about the serviceability-dev
mailing list