RFR: JDK-8304163: Move jdk.internal.module.ModuleInfoWriter to the test library [v2]
Leonid Mesnik
lmesnik at openjdk.org
Mon Mar 20 01:37:23 UTC 2023
On Sat, 18 Mar 2023 19:14:09 GMT, Mandy Chung <mchung at openjdk.org> wrote:
>> `ModuleInfoWriter` is not used by the runtime. Move it to the test library as `jdk.test.lib.util.ModuleInfoWriter`. The tests are updated to use the test library instead. `ModuleInfoWriter` depends on `jdk.internal.module` types and the Classfile API. Hence `@modules java.base/jdk.internal.classfile` and other classfile subpackages are added.
>
> Mandy Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> move @library after @modules per the recommended ordering
Changes requested by lmesnik (Reviewer).
test/jdk/java/lang/ModuleTests/AnnotationsTest.java line 61:
> 59: * java.base/jdk.internal.module
> 60: * @library /test/lib
> 61: * @build jdk.test.lib.util.ModuleInfoWriter
You don't need to build library classes explicitly. I think @library /test/lib it enough.
-------------
PR: https://git.openjdk.org/jdk/pull/13085
More information about the serviceability-dev
mailing list