RFR: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

Eirik Bjorsnos duke at openjdk.org
Mon Mar 20 21:04:31 UTC 2023


Please review this PR which removes the following outdated guard/check from SunCommandLineLauncher:


if ((options.indexOf("-Djava.compiler=") != -1) &&
    (options.toLowerCase().indexOf("-djava.compiler=none") == -1)) {
    throw new IllegalConnectorArgumentsException("Cannot debug with a JIT compiler",
                                                 ARG_OPTIONS);
}



Efforts are underway to remove the `java.compiler` system property entirely, besides that this test no longer makes sense since debugging with a JIT has been supported for a while.

-------------

Commit messages:
 - Remove check of java.compiler since the property is being removed and the thing tested is no longer valid (debugging works fine with JITs)

Changes: https://git.openjdk.org/jdk/pull/13109/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13109&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8304547
  Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/13109.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13109/head:pull/13109

PR: https://git.openjdk.org/jdk/pull/13109


More information about the serviceability-dev mailing list