RFR: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

[Chris Plummer]

On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> Please review this PR which removes the following outdated guard/check from SunCommandLineLauncher:
> 
> 
> if ((options.indexOf("-Djava.compiler=") != -1) &&
>     (options.toLowerCase().indexOf("-djava.compiler=none") == -1)) {
>     throw new IllegalConnectorArgumentsException("Cannot debug with a JIT compiler",
>                                                  ARG_OPTIONS);
> }
> 
> 
> 
> Efforts are underway to remove the `java.compiler` system property entirely, besides that this test no longer makes sense since debugging with a JIT has been supported for a while.

Marked as reviewed by cjplummer (Reviewer).

Please make sure you run the jdk/com/sun/jdi tests and the jdb, jdwp, and jdi test under hotspot/jtreg/vmTestbase/nsk

-------------

PR Review: https://git.openjdk.org/jdk/pull/13109#pullrequestreview-1349632141
PR Comment: https://git.openjdk.org/jdk/pull/13109#issuecomment-1477208049