RFR: 8301995: Move invokedynamic resolution information out of ConstantPoolCacheEntry [v9]

Andrew Haley aph at openjdk.org
Tue Mar 21 22:24:51 UTC 2023


On Tue, 21 Mar 2023 17:40:46 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/templateTable_aarch64.cpp line 2337:
>> 
>>> 2335:   // Load-acquire the adapter method
>>> 2336:   __ lea(method, Address(cache, in_bytes(ResolvedIndyEntry::method_offset())));
>>> 2337:   __ ldar(method, method);
>> 
>> What reordering are we trying to prevent here?
>
> The loads of the data stored in `ResolvedIndyEntry::fill_in()` must not be reordered with loading  `ResolvedIndyEntry::_method`.

Ah, I see. This acquiring load matches the releasing store in `fill_in()`. Please add a comment here to that effect.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12778#discussion_r1144047014


More information about the serviceability-dev mailing list