RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v4]

Serguei Spitsyn sspitsyn at openjdk.org
Thu Mar 23 05:46:42 UTC 2023


On Thu, 23 Mar 2023 02:00:56 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor cleanup in enable_virtual_threads_notify_jvmti()
>
> src/hotspot/share/prims/jvmtiEnvBase.hpp line 87:
> 
>> 85: 
>> 86:   static bool enable_virtual_threads_notify_jvmti();
>> 87:   static bool disable_virtual_threads_notify_jvmti();
> 
> "disable" only seems to be used by the WB API. Is that expected?

Yes, this is from the PR description:
> New function JvmtiEnvBase::disable_virtual_threads_notify_jvmti() which is needed for testing.
> It is used by the WhiteBox API.

Do you think a comment is needed?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1145702749


More information about the serviceability-dev mailing list