RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v5]

[Serguei Spitsyn]

On Thu, 23 Mar 2023 17:49:31 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comment: remove unneeded function
>
> src/hotspot/share/prims/jvmtiThreadState.hpp line 101:
> 
>> 99:   static void set_VTMS_notify_jvmti_events(bool val) { _VTMS_notify_jvmti_events = val; }
>> 100: 
>> 101:   static void set_VTMS_transition_count(bool val)    { _VTMS_transition_count = val; }
> 
> Why set the count if it is never going to be used?

The counter `_VTMS_transition_count` is directly used by the `jvmtiVTMSTransitionDisabler`.

> test/hotspot/jtreg/serviceability/jvmti/vthread/ToggleNotifyJvmtiTest/ToggleNotifyJvmtiTest.java line 38:
> 
>> 36:  */
>> 37: 
>> 38: //import compiler.whitebox.CompilerWhiteBoxTest;
> 
> Remove

Thanks. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1146994030
PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1146994886