RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v5]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Mar 24 00:43:34 UTC 2023


On Thu, 23 Mar 2023 18:07:23 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comment: remove unneeded function
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/ToggleNotifyJvmtiTest/ToggleNotifyJvmtiTest.java line 161:
> 
>> 159:             vm.loadAgentLibrary(AGENT_LIB, arg);
>> 160:         } else {
>> 161:             System.loadLibrary(AGENT_LIB);
> 
> Why is this needed? Isn't the library already loaded due to it being specified by `-agentlib`?

Good question. We almost always do it in the JVMTI tests including `serviceability/jvmti/vthread` and `vmTestbase/nsk/jvmti` tests. Examples are 22 `serviceability/jvmti/vthread` tests.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1147009306


More information about the serviceability-dev mailing list