RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v5]

[Serguei Spitsyn]

On Thu, 23 Mar 2023 22:11:58 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comment: remove unneeded function
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 1581:
> 
>> 1579:     return false;
>> 1580:   }
>> 1581:   if (JvmtiVTMSTransitionDisabler::VTMS_notify_jvmti_events()) {
> 
> shouldn't be
>  if (!JvmtiVTMSTransitionDisabler::VTMS_notify_jvmti_events()) {
> here?

This is nice catch, thanks!

> test/hotspot/jtreg/serviceability/jvmti/vthread/ToggleNotifyJvmtiTest/ToggleNotifyJvmtiTest.java line 82:
> 
>> 80:         try {
>> 81:             while (!threadReady) {
>> 82:                 sleep(1);
> 
> Use ToggleNotifyJvmtiTest.sleep(1);?

Good idea, thanks. Simplified.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1147044376
PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1147043984