RFR: 8297286: runtime/vthread tests crashing after JDK-8296324 [v5]

[Serguei Spitsyn]

On Thu, 23 Mar 2023 22:18:51 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comment: remove unneeded function
>
> src/hotspot/share/prims/whitebox.cpp line 2537:
> 
>> 2535:   }
>> 2536: #endif
>> 2537:   return result;
> 
> The test never check results, so it might be better to generate fatal error and fail here/throw exception to catch bug earlier?

Thank you for the comment.
I think, the decision to throw exception has to be in the test.
Modified the test as below:

<<<        WB.setVirtualThreadsNotifyJvmtiMode(enable);
 ---
>>>        boolean status = WB.setVirtualThreadsNotifyJvmtiMode(enable);
>>>        if (!status) {
>>>            throw new RuntimeException("Java: failed to set VirtualThreadsNotifyJvmtiMode: " + enable);
>>>        }

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13133#discussion_r1147075146