Integrated: 8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

Eirik Bjorsnos duke at openjdk.org
Mon Mar 27 14:37:25 UTC 2023


On Mon, 20 Mar 2023 20:53:41 GMT, Eirik Bjorsnos <duke at openjdk.org> wrote:

> Please review this PR which removes the following outdated guard/check from SunCommandLineLauncher:
> 
> 
> if ((options.indexOf("-Djava.compiler=") != -1) &&
>     (options.toLowerCase().indexOf("-djava.compiler=none") == -1)) {
>     throw new IllegalConnectorArgumentsException("Cannot debug with a JIT compiler",
>                                                  ARG_OPTIONS);
> }
> 
> 
> 
> Efforts are underway to remove the `java.compiler` system property entirely, besides that this test no longer makes sense since debugging with a JIT has been supported for a while.

This pull request has now been integrated.

Changeset: 46b06023
Author:    Eirik Bjorsnos <eirbjo at gmail.com>
Committer: Alan Bateman <alanb at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/46b0602376893df204bf4d624938bf89abe04d89
Stats:     7 lines in 1 file changed: 0 ins; 6 del; 1 mod

8304547: Remove checking of -Djava.compiler in src/jdk.jdi/share/classes/com/sun/tools/jdi/SunCommandLineLauncher.java

Reviewed-by: dholmes, cjplummer, alanb

-------------

PR: https://git.openjdk.org/jdk/pull/13109


More information about the serviceability-dev mailing list