RFR: 8307067: remove broken EnableThreadSMRExtraValidityChecks option

David Holmes dholmes at openjdk.org
Tue May 2 08:08:16 UTC 2023


On Thu, 27 Apr 2023 22:17:30 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> A trivial fix to remove broken EnableThreadSMRExtraValidityChecks option.

One minor nit but otherwise good. Thanks.

src/hotspot/share/runtime/threadSMR.cpp line 828:

> 826:   if (java_thread != JavaThread::current()) {
> 827:     // java_thread is not the current JavaThread so we have to verify it
> 828:     // against the ThreadsList:

Colon at the end of the comment seems odd

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13704#pullrequestreview-1408596858
PR Review Comment: https://git.openjdk.org/jdk/pull/13704#discussion_r1182218848


More information about the serviceability-dev mailing list