RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v2]

Coleen Phillimore coleenp at openjdk.org
Tue May 2 15:44:18 UTC 2023


On Sat, 29 Apr 2023 15:54:23 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The `finalize()` method is removed from base classes/interfaces and are replaced by a Cleaner callback..
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests

This looks good to me with correcting mashine typo.  We should file another RFE to rename these classes and methods and fix all the comments, many containing typos and let the hotspot/srv take care of that.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13420#pullrequestreview-1409376718


More information about the serviceability-dev mailing list