RFR: 8307305: Update debugger tests to support JTREG_TEST_THREAD_FACTORY mode

Leonid Mesnik lmesnik at openjdk.org
Wed May 3 02:48:12 UTC 2023


On Wed, 3 May 2023 00:38:17 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> I think MainWrapper.java could use some documentation on why/how/when it used. This is something that should have been done before first committing it when loom changes were integrated.
> 
> Also, I see what looks like a bug w.r.t. this code in Launcher.java:
> 
> ```
>             if (System.getProperty("main.wrapper") != null) {
>                 cmdline = MainWrapper.class.getName() + " " + System.getProperty("main.wrapper") +  " " + cmdline;
>             }
> ```
> 
> It gets the main.wrapper property in order to pass it to MainWrapper.main(), which is in charge of setting the properly, so how could it ever already be set when this Launcher.java code is executed? Same thing in Binder.java and DebugeeBinder.java.

let me file sub-task to add documentation about using "main.wrapper" as a part of https://bugs.openjdk.org/browse/JDK-8303773.

Currently, it is propagated to debugee as a part of `test.vm.opts` . However the goal is to use `JTREG_TEST_THREAD_FACTORY` which set Virtual test thread factory and set all required properties. So it is needed to manually set them in debugee while launching them using nsk Wrapper or TestScaffold.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13763#issuecomment-1532394277


More information about the serviceability-dev mailing list