RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v2]

Wed May 3 05:45:15 UTC 2023

On Tue, 2 May 2023 15:39:49 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> test/hotspot/jtreg/vmTestbase/nsk/share/Finalizable.java line 48:
>> 
>>> 46:      * It is implemented in FinalizableObject.
>>> 47:      */
>>> 48:     public void registerCleanup();
>> 
>> Can you not implement this as a default method?
>
> It seems much better to force implementors to provide this method.

Why? They all seem to do exactly the same thing.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1183256509