RFR: 8307448: Test RedefineSharedClassJFR fail due to wrong assumption

Stefan Johansson sjohanss at openjdk.org
Thu May 4 12:52:23 UTC 2023


On Thu, 4 May 2023 12:36:27 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this fix to avoid a tier1 test failure.
>> 
>> **Summary**
>> The newly added test wrongfully assumed that one of the transformed classes would be in use. This seem to be the case in most runs, but there is no guarantee. This change fixes the test to only verify that nothing is seen as shared when running with -Xshare:off.
>> 
>> **Testing**
>> Verified that the test still passes locally.
>
> Thanks for fixing this so quickly.

Thanks @coleenp and @fisk for the quick reviews. 

Since the test failure shows up in tier 1 I will push this without waiting 24 hours.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/13801#issuecomment-1534718633


More information about the serviceability-dev mailing list