RFR: JDK-8307331: Correctly update line maps when class redefine rewrites bytecodes
Dan Heidinga
heidinga at openjdk.org
Thu May 4 17:40:15 UTC 2023
On Thu, 4 May 2023 17:17:19 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> This small change ensures that repeated bytecode rewrites necessitated by class pool index updates are applied cumulatively when updating the method line number table. The current code applies each change to the original table which means only the last one is applied (and even then with the wrong adjustment).
>
> @coleenp @plummercj Any chance of feedback or a review for this patch?
@adinn Looking at the closely related code, is the same problem present for `adjust_exception_table` & `adjust_local_var_table`? Both appear to always reach for the original value from the method, though unlike the line number table, there's no member variable cached in the Relocator for either of them.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/13795#issuecomment-1535160190
More information about the serviceability-dev
mailing list