RFR: 8307370: Add tier1 testing with thread factory in CI
Serguei Spitsyn
sspitsyn at openjdk.org
Fri May 5 03:49:14 UTC 2023
On Fri, 5 May 2023 00:47:58 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
> This fix just excludes a few hotspot/jdk tests which are not compatible with test thread factory. So
> `make -- run-test JTREG_VERBOSE=all JTREG_RETAIN=all JTREG_TEST_THREAD_FACTORY=Virtual TEST=:tier1`
> could be executed clearly.
The update looks okay but I've posted some nits.
Thanks,
Serguei
test/hotspot/jtreg/ProblemList-Virtual.txt line 135:
> 133: ## Tests incompatible with with virtual test thread factory
> 134: ## There is no goal to run all test with virtual test thread factory
> 135: ## So any test migth be added as incompatible, the
A typo at line 133: "with with". Dot is missed at the end.
It seems, both statements at 134-135 are incomplete.
First misses dot at the end, second ended with "the" and has no dot as well.
test/jdk/ProblemList-Virtual.txt line 56:
> 54: ## Tests incompatible with with virtual test thread factory
> 55: ## There is no goal to run all test with virtual test thread factory
> 56: ## So any test migth be added as incompatible, the
A typo at line 64: "with with". Dot is missed at the end.
It seems, both statements at 55-56 are incomplete.
First misses dot at the end, second ended with "the" and has no dot as well.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13820#pullrequestreview-1414143094
PR Review Comment: https://git.openjdk.org/jdk/pull/13820#discussion_r1185674577
PR Review Comment: https://git.openjdk.org/jdk/pull/13820#discussion_r1185673789
More information about the serviceability-dev
mailing list