RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v2]

[Serguei Spitsyn]

On Sat, 29 Apr 2023 15:54:23 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The `finalize()` method is removed from base classes/interfaces and are replaced by a Cleaner callback..
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests

test/hotspot/jtreg/vmTestbase/nsk/share/Finalizable.java line 44:

> 42: 
> 43:     /*
> 44:      * This method will register a cleanup method and creates an instance of Finalizer

Nit: `creates` => `create`

test/hotspot/jtreg/vmTestbase/nsk/share/LocalProcess.java line 167:

> 165: 
> 166:     /**
> 167:      * This method is called at finalization and calls  <code>kill()</code>.

Nit: Extra space after `and calls`.

test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java line 99:

> 97:     private int busyRequests = 0;
> 98: 
> 99: 

Nit: Unneeded extra line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1185769380
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1185770457
PR Review Comment: https://git.openjdk.org/jdk/pull/13420#discussion_r1185772007