RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri May 5 07:25:19 UTC 2023


On Sat, 29 Apr 2023 15:54:23 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> The `finalize()` method is removed from base classes/interfaces and are replaced by a Cleaner callback..
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests

Looks okay to me but posted some nits.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13420#pullrequestreview-1414290300


More information about the serviceability-dev mailing list