RFR: 8299414: JVMTI FollowReferences should support references from VirtualThread stack [v9]
Alex Menkov
amenkov at openjdk.org
Fri May 5 22:36:21 UTC 2023
On Fri, 5 May 2023 05:48:04 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> JNI local reporting uses this tricky _is_top_frame/_last_entry_frame stuff
>> I think it would be better to have it in the main do_frame method for better readability
>
> Sorry, I do not see how this improves readability.
> Big functions with many layered conditions do not improve readability.
I mean the pieces of the code that set and use _is_top_frame/_last_entry_frame are close so it's easier to see the logic
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13254#discussion_r1186539125
More information about the serviceability-dev
mailing list