RFR: JDK-8300245: Replace NULL with nullptr in share/jfr/ [v8]

Johan Sjölen jsjolen at openjdk.org
Mon May 8 10:09:29 UTC 2023


> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/jfr/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
> 
> Here are some typical things to look out for:
> 
>     No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
>     Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
>     nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
> 
> An example of this:
> 
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
> 
> Note how nullptr participates in a code expression here, we really are talking about the specific value nullptr.
> 
> Thanks!

Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:

  Dead assert

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/12034/files
  - new: https://git.openjdk.org/jdk/pull/12034/files/cb705720..6018ab38

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=12034&range=07
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12034&range=06-07

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/12034.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/12034/head:pull/12034

PR: https://git.openjdk.org/jdk/pull/12034


More information about the serviceability-dev mailing list