RFR: 8306843: JVMTI tag map extremely slow after JDK-8292741 [v2]
    Coleen Phillimore 
    coleenp at openjdk.org
       
    Mon May  8 14:02:33 UTC 2023
    
    
  
On Mon, 8 May 2023 05:25:04 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> src/hotspot/share/utilities/resourceHash.hpp line 147:
>> 
>>> 145:   */
>>> 146:   bool put_fast(K const& key, V const& value) {
>>> 147:     unsigned hv = HASH(key);
>> 
>> I think `put_fast` is not clear enough. Maybe `put_must_be_absent()` or something more concise.
>
> I would suggest `put_when_absent` to complement `put_if_absent` - with suitable descriptive comments of course.
This is a good name.  Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13818#discussion_r1187483386
    
    
More information about the serviceability-dev
mailing list