RFR: 8307480: Improve SA "transported core" documentation for windows

Chris Plummer cjplummer at openjdk.org
Mon May 8 18:23:16 UTC 2023


On Sat, 6 May 2023 09:45:07 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> The SA document `transported_core.html` contains some tips on getting core files to work when debugging it on a machine other than the one that produced it. There are a few improvements that can be made based on information provided in [JDK-8306437](https://bugs.openjdk.org/browse/JDK-8306437) and in the #13836 review (which was eventually pulled as not necessary).
>> 
>> Updates to the document include the use of `sun.jvm.hotspot.debugger.windbg.imagePath` and `sun.jvm.hotspot.debugger.windbg.symbolPath` properties, and adding "`srv*https://msdl.microsoft.com/download/symbols`" to symbolPath.
>> 
>> The rendered html file with these changes can be found here:
>> https://htmlpreview.github.io/?https://raw.githubusercontent.com/openjdk/jdk/baa6b36cd5b9c5b953fd9f5b8f4461bd4107ee05/src/jdk.hotspot.agent/doc/transported_core.html
>
> src/jdk.hotspot.agent/doc/transported_core.html line 94:
> 
>> 92: 
>> 93: <p>
>> 94: How you set these properties will depend on the SA tool being used. The following in an example of when launching the clhsdb tool:
> 
> Typo?: `The following in an example of when launching...` => `The following is an example of launching...`.

Yes, or maybe "for launching".  It's somewhat of a clumsy sentence, but the only fix for that I've come up with for that makes it kind of wordy: "The following example demonstrates how to set one of the properties when launching the clhsdb tool:"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13849#discussion_r1187748321


More information about the serviceability-dev mailing list