Integrated: JDK-8300245: Replace NULL with nullptr in share/jfr/
Johan Sjölen
jsjolen at openjdk.org
Wed May 10 12:38:44 UTC 2023
On Tue, 17 Jan 2023 11:26:12 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> Hi, this PR changes all occurrences of NULL to nullptr for the subdirectory share/jfr/. Unfortunately the script that does the change isn't perfect, and so we
> need to comb through these manually to make sure nothing has gone wrong. I also review these changes but things slip past my eyes sometimes.
>
> Here are some typical things to look out for:
>
> No changes but copyright header changed (probably because I reverted some changes but forgot the copyright).
> Macros having their NULL changed to nullptr, these are added to the script when I find them. They should be NULL.
> nullptr in comments and logs. We try to use lower case "null" in these cases as it reads better. An exception is made when code expressions are in a comment.
>
> An example of this:
>
> // This function returns null
> void* ret_null();
> // This function returns true if *x == nullptr
> bool is_nullptr(void** x);
>
> Note how nullptr participates in a code expression here, we really are talking about the specific value nullptr.
>
> Thanks!
This pull request has now been integrated.
Changeset: cc396895
Author: Johan Sjölen <jsjolen at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/cc396895e5a1dac49f4e341ce91c04b8c092d0af
Stats: 2070 lines in 125 files changed: 1 ins; 5 del; 2064 mod
8300245: Replace NULL with nullptr in share/jfr/
Reviewed-by: mgronlun, coleenp
-------------
PR: https://git.openjdk.org/jdk/pull/12034
More information about the serviceability-dev
mailing list