RFR: 8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests [v2]

Afshin Zafari duke at openjdk.org
Wed May 10 14:40:28 UTC 2023


On Tue, 9 May 2023 15:55:48 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8305083: Remove finalize() from test/hotspot/jtreg/vmTestbase/nsk/share/ and /jpda that are used in serviceability/dcmd/framework tests
>
> test/hotspot/jtreg/vmTestbase/nsk/share/LocalProcess.java line 170:
> 
>> 168:      *
>> 169:      */
>> 170:     public void cleanup() {
> 
> Maybe add `@Override`

Fixed.

> test/hotspot/jtreg/vmTestbase/nsk/share/jpda/BindServer.java line 410:
> 
>> 408:      * @see #close()
>> 409:      */
>> 410:     public void cleanup() {
> 
> Add `@Override`

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13884#discussion_r1189995149
PR Review Comment: https://git.openjdk.org/jdk/pull/13884#discussion_r1189996545


More information about the serviceability-dev mailing list